hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lei (Eddy) Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9835) OIV: add ReverseXML processor which reconstructs an fsimage from an XML file
Date Fri, 26 Feb 2016 21:54:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169908#comment-15169908
] 

Lei (Eddy) Xu commented on HDFS-9835:
-------------------------------------

Hi, [~cmccabe] Thanks for working on it. It looks nice.

A few small nitpicks:

{code}
   int encodedName = xattr.getName();
   int ns = (0x3 & (encodedName >> 30)) |
         ((0x1 & (encodedName >> 5)) << 2);
   o("ns", XAttrProtos.XAttrProto.
        XAttrNamespaceProto.valueOf(ns).toString());
  o("name", stringTable[0xffffff & (encodedName >> 6)]);
{code}

Can we use {{FSImageFormatPBINode.XATTR_...}} constants here to make it more readable?

 {code}
for (int refId : e.getRefChildrenList()) {
     o("refchild", refId);
}
{code}

"refchild" -> "refChild" ?

Will +1 once they are addressed.


> OIV: add ReverseXML processor which reconstructs an fsimage from an XML file
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-9835
>                 URL: https://issues.apache.org/jira/browse/HDFS-9835
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: tools
>    Affects Versions: 2.0.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-9835.001.patch, HDFS-9835.002.patch, HDFS-9835.003.patch
>
>
> OIV: add ReverseXML processor which reconstructs an fsimage from an XML file.  This will
make it easy to create fsimages for testing, and manually edit fsimages when there is corruption.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message