hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9816) Erasure Coding: allow to use multiple EC policies in striping related tests [Part 3]
Date Fri, 19 Feb 2016 23:02:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155090#comment-15155090
] 

Zhe Zhang commented on HDFS-9816:
---------------------------------

Thanks Rui for the update. I just realized that {{TestStripedINodeFile#computeExpectedSize}}
and {{TestStripedBlockUtil#computeExpectedSizes}} have the same issue as Walter raised above.
Before the patch, we are testing whether the production code {{spaceConsumedByStripedBlock}}
and {{getInternalBlockLength}} are generating expected results. But the added {{computeExpectedxx}}
methods in the patch repeat production code. I understand the motivation is to support multiple
EC policies. But I guess hard-coded value cannot be easily avoided in these 2 cases. How about
we revert these 2 changes, and extend the tests to something like {{testBlockStripedConsumedSpace-10-4}},
{{testBlockStripedConsumedSpace-6-3}} when we do add more policies?

> Erasure Coding: allow to use multiple EC policies in striping related tests [Part 3]
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-9816
>                 URL: https://issues.apache.org/jira/browse/HDFS-9816
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding, test
>            Reporter: Rui Li
>            Assignee: Rui Li
>         Attachments: HDFS-9816.1.patch, HDFS-9816.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message