hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Hansen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9791) libhfds++: ConfigurationLoader throws parse_exception on invalid input
Date Thu, 18 Feb 2016 15:24:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152441#comment-15152441
] 

Bob Hansen commented on HDFS-9791:
----------------------------------

Adding a Status to the return is going to make the API very messy.  We should think more deeply
about it and revisit it as part of another bug.

> libhfds++: ConfigurationLoader throws parse_exception on invalid input
> ----------------------------------------------------------------------
>
>                 Key: HDFS-9791
>                 URL: https://issues.apache.org/jira/browse/HDFS-9791
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Bob Hansen
>            Assignee: Bob Hansen
>         Attachments: HDFS-9791.HDFS-8707.000.patch
>
>
> The coding style for libhdfs++ is to return Status objects rather than throwing exceptions.
 The interface for ConfigurationLoader should switch out bools for Status objects, and ConfigurationLoader::UpdateMapWithBytes
(and any other place we interact wtih rapidxml) should catch rapidxml exceptions, returning
an appropriate Status message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message