hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9773) Remove dead code related to SimulatedFSDataset in tests
Date Fri, 12 Feb 2016 07:05:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144187#comment-15144187
] 

Akira AJISAKA commented on HDFS-9773:
-------------------------------------

Thanks [~brahmareddy] for creating the patch. Would you replace 
{code:title=TestFileAppend.java}
    if (simulatedStorage) {
      LocatedBlocks lbs = fileSys.getClient().getLocatedBlocks(name.toString(),
          0, AppendTestUtil.FILE_SIZE);
      DFSTestUtil.fillExpectedBuf(lbs, expected);
    } else {
      System.arraycopy(fileContents, 0, expected, 0, expected.length);
    }
{code}
with
{code}
    System.arraycopy(fileContents, 0, expected, 0, expected.length);
{code}
and remove {{simulatedStorage}}?

> Remove dead code related to SimulatedFSDataset in tests
> -------------------------------------------------------
>
>                 Key: HDFS-9773
>                 URL: https://issues.apache.org/jira/browse/HDFS-9773
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>            Reporter: Akira AJISAKA
>            Assignee: Brahma Reddy Battula
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-9773-002.patch, HDFS-9773.patch
>
>
> There are some dead code
> {code}
>   final boolean simulatedStorage = false;
>   if (simulatedStorage) {
>     SimulatedFSDataset.setFactory(conf);
>   }
> {code}
> in TestShortCircuitLocalRead, TestFileAppend, TestFileAppend2, TestFileAppend4, and TestLargeBlock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message