hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9755) Erasure Coding: allow to use multiple EC policies in striping related tests [Part 2]
Date Fri, 05 Feb 2016 19:18:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134759#comment-15134759
] 

Zhe Zhang commented on HDFS-9755:
---------------------------------

Thanks Rui! Great quality improvement work. +1 pending the below minor issue:
{code}
int lastGroupDataLen = fileLen % (dataBlkNum * blockSize);
{code}
Strictly speaking, this is incorrect when {{fileLen == 0}}. So maybe add an assertion that
{{fileLen}} is positive?

A follow-on is to make the tests in {{TestReconstructStripedFile}} more systematic. But I
don't think that's very urgent.

> Erasure Coding: allow to use multiple EC policies in striping related tests [Part 2]
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-9755
>                 URL: https://issues.apache.org/jira/browse/HDFS-9755
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding, test
>            Reporter: Rui Li
>            Assignee: Rui Li
>         Attachments: HDFS-9755.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message