hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9733) Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum
Date Mon, 22 Feb 2016 06:49:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156555#comment-15156555
] 

Kai Zheng commented on HDFS-9733:
---------------------------------

Thanks Uma for the great comments!
bq. Why do you think we need 2 abstract classes here?
Ah right now we do just need one abstract class for the refactoring. The other can be introduced
later in HDFS-9694 when it's really needed.
bq. Could you please add doc for this class? 
Sure for this and the other similar comments. I will add javadoc for the new class and public/protected
methods. 
bq. How does this class related?
Oh, CorruptedBlocks was from the work in HDFS-9734. I will do the cleanup when update the
patch.

> Refactor DFSClient#getFileChecksum and DataXceiver#blockChecksum
> ----------------------------------------------------------------
>
>                 Key: HDFS-9733
>                 URL: https://issues.apache.org/jira/browse/HDFS-9733
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HDFS-9733-v1.patch, HDFS-9733-v2.patch, HDFS-9733-v3.patch
>
>
> To prepare for file checksum computing for striped files, this refactors the existing
codes in Refactor {{DFSClient#getFileChecksum}} and {{DataXceiver#blockChecksum}} to make
HDFS-8430 and HDFS-9694 easier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message