hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lin Yiqun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9713) DataXceiver#copyBlock should return if block is pinned
Date Wed, 03 Feb 2016 01:51:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129580#comment-15129580
] 

Lin Yiqun commented on HDFS-9713:
---------------------------------

That's a problem here.In DataXceiver#copyBlock:
{code}
if (datanode.data.getPinning(block)) {
      String msg = "Not able to copy block " + block.getBlockId() + " " +
          "to " + peer.getRemoteAddressString() + " because it's pinned ";
      LOG.info(msg);
      sendResponse(ERROR, msg);
    }
    
    if (!dataXceiverServer.balanceThrottler.acquire()) { // not able to start
      String msg = "Not able to copy block " + block.getBlockId() + " " +
          "to " + peer.getRemoteAddressString() + " because threads " +
          "quota is exceeded.";
      LOG.warn(msg);
      sendResponse(ERROR, msg);
      return;
    }
{code}
One logic have returned, and the other is not. [~umamaheswararao], this jira have not updated
many days, you can assign to me if you have not time to do with it.

> DataXceiver#copyBlock should return if block is pinned
> ------------------------------------------------------
>
>                 Key: HDFS-9713
>                 URL: https://issues.apache.org/jira/browse/HDFS-9713
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.7.2
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>
> in DataXceiver#copyBlock
> {code}
>   if (datanode.data.getPinning(block)) {
>       String msg = "Not able to copy block " + block.getBlockId() + " " +
>           "to " + peer.getRemoteAddressString() + " because it's pinned ";
>       LOG.info(msg);
>       sendResponse(ERROR, msg);
>     }
> {code}
> I think we should return back instead of proceeding to send block.as we already sent
ERROR here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message