hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9395) HDFS operations vary widely in which failures they put in the audit log and which they leave out
Date Tue, 09 Feb 2016 05:46:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138385#comment-15138385

Vinayakumar B commented on HDFS-9395:

Thanks [~kshukla] for the updated patch.

1. Following can be moved out of finally block.
{code}      logAuditEvent(success, "setErasureCodingPolicy", srcArg, null,

2. Not related to patch, but can be included, {{if (auditLog.isInfoEnabled() && isExternalInvocation())}}
can be removed in {{startRollingUpgrade}} and {{finalizeRollingUpgrade}}, as its checked inside
{{logAuditEvent(..)}} too.
    if (auditLog.isInfoEnabled() && isExternalInvocation()) {
      logAuditEvent(true, "startRollingUpgrade", null, null, null);

{{getAclStatus()}}, {{getXAttrs(..)}}, {{listXAttrs}} missing, successfull auditlog.

> HDFS operations vary widely in which failures they put in the audit log and which they
leave out
> ------------------------------------------------------------------------------------------------
>                 Key: HDFS-9395
>                 URL: https://issues.apache.org/jira/browse/HDFS-9395
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Kihwal Lee
>            Assignee: Kuhu Shukla
>         Attachments: HDFS-9395.001.patch, HDFS-9395.002.patch, HDFS-9395.003.patch, HDFS-9395.004.patch,
> So, the big question here is what should go in the audit log? All failures, or just "permission
denied" failures? Or, to put it a different way, if someone attempts to do something and it
fails because a file doesn't exist, is that worth an audit log entry?
> We are currently inconsistent on this point. For example, concat, getContentSummary,
addCacheDirective, and setErasureEncodingPolicy create an audit log entry for all failures,
but setOwner, delete, and setAclEntries attempt to only create an entry for AccessControlException-based
failures. There are a few operations, like allowSnapshot, disallowSnapshot, and startRollingUpgrade
that never create audit log failure entries at all. They simply log nothing for any failure,
and log success for a successful operation.
> So to summarize, different HDFS operations currently fall into 3 categories:
> 1. audit-log all failures
> 2. audit-log only AccessControlException failures
> 3. never audit-log failures
> Which category is right?  And how can we fix the inconsistency

This message was sent by Atlassian JIRA

View raw message