Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3F7421818A for ; Fri, 8 Jan 2016 14:39:40 +0000 (UTC) Received: (qmail 76819 invoked by uid 500); 8 Jan 2016 14:39:40 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 76761 invoked by uid 500); 8 Jan 2016 14:39:40 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 76742 invoked by uid 99); 8 Jan 2016 14:39:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 14:39:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D88C12C1F57 for ; Fri, 8 Jan 2016 14:39:39 +0000 (UTC) Date: Fri, 8 Jan 2016 14:39:39 +0000 (UTC) From: "Bob Hansen (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9627) libhdfs++: Add a mechanism to retrieve human readable error messages through the C API MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089282#comment-15089282 ] Bob Hansen commented on HDFS-9627: ---------------------------------- Additional minor comment: for consistency, we should mark the methods as {{LIBHDFS_EXTERNAL}}, which means including {{hdfs.h}}, which means we need to disambiguate the C {{hdfs.h}} from the libdhfdspp {{hdfs.h}} (which declares FileSystem and FileHandle). Perhaps renaming this patch's {{hdfspp.h}} to {{hdfs_ext.h}} and renaming {{libhdfs/include/libhdfspp/hdfs.h}} to {{hdfspp.h}} is a good set of names? Nothing is ever simple. > libhdfs++: Add a mechanism to retrieve human readable error messages through the C API > -------------------------------------------------------------------------------------- > > Key: HDFS-9627 > URL: https://issues.apache.org/jira/browse/HDFS-9627 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client > Reporter: James Clampffer > Assignee: James Clampffer > Attachments: HDFS-9627.HDFS-8707.000.patch, HDFS-9627.HDFS-8707.000.patch > > > Libhdfs doesn't have this but libhdfs3 has a "hdfsGetLastErrorString" function. The C API needs to be able to pass out error messages that are more specific than what errno can provide. > This functionality should be exposed via a new public header in order to keep hdfs.h consistent with the libhdfs header. -- This message was sent by Atlassian JIRA (v6.3.4#6332)