Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 15 Jan 2016 19:25:39 +0000 (UTC)
From: "Andrew Wang (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12926856.1451873178000.125103.1452885939796@Atlassian.JIRA>
In-Reply-To: <JIRA.12926856.1451873178000@Atlassian.JIRA>
References: <JIRA.12926856.1451873178000@Atlassian.JIRA>
 <JIRA.12926856.1451873178229@arcas>
Subject: [jira] [Commented] (HDFS-9608) Disk IO imbalance in HDFS with
 heterogeneous storages
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102339#comment-15102339 ] 

Andrew Wang commented on HDFS-9608:
-----------------------------------

Patch doesn't apply for me either, also a small nit when you rebase, javadoc is associated with the immediately following member, so recommend either splitting the syncLocks doc out to be above the syncLocks variable, or just change it to a plain block comment instead of javadoc e.g.:

{noformat}
/*
{noformat}

Unit test failures also look related.

> Disk IO imbalance in HDFS with heterogeneous storages
> -----------------------------------------------------
>
>                 Key: HDFS-9608
>                 URL: https://issues.apache.org/jira/browse/HDFS-9608
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>         Attachments: HDFS-9608.01.patch, HDFS-9608.02.patch, HDFS-9608.03.patch
>
>
> Currently RoundRobinVolumeChoosingPolicy use a shared index to choose volumes in HDFS with heterogeneous storages, this leads to non-RR choosing mode for certain type of storage.
> Besides, it uses a shared lock for synchronization which limits the concurrency of volume choosing process. Volume choosing threads that operating on different storage types should be able to run concurrently. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)