Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4EBAE18DF7 for ; Mon, 4 Jan 2016 12:33:40 +0000 (UTC) Received: (qmail 80509 invoked by uid 500); 4 Jan 2016 12:33:40 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 80453 invoked by uid 500); 4 Jan 2016 12:33:40 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 80437 invoked by uid 99); 4 Jan 2016 12:33:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2016 12:33:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DCBC42C1F56 for ; Mon, 4 Jan 2016 12:33:39 +0000 (UTC) Date: Mon, 4 Jan 2016 12:33:39 +0000 (UTC) From: "Kai Zheng (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9603) Erasure Coding: Use ErasureCoder to encode/decode a block group MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081090#comment-15081090 ] Kai Zheng commented on HDFS-9603: --------------------------------- Thanks Rui for the nice patch! For this util, {{public static RSErasureEncoder createRSEncoder}}, I understand it since we only have one workable {{ErasureCoder}} for the moment. I guess we can hold on this to wait for the HitchHicker coder to be available so try it here. Anyway, it should be {{public static ErasureCoder createErasureEncoder}} or the similar and it should return a concrete erasure coder according to configuration (not necessarily is the RS one). A minor, please avoid star import. > Erasure Coding: Use ErasureCoder to encode/decode a block group > --------------------------------------------------------------- > > Key: HDFS-9603 > URL: https://issues.apache.org/jira/browse/HDFS-9603 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Rui Li > Assignee: Rui Li > Attachments: HDFS-9603.1.patch > > > According to design, {{ErasureCoder}} is responsible to encode/decode a block group. Currently however, we directly use {{RawErasureCoder}} to do the work, e.g. in {{DFSStripedOutputStream}}. This task attempts to encapsulate {{RawErasureCoder}} to comply with the design. -- This message was sent by Atlassian JIRA (v6.3.4#6332)