Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 11 Jan 2016 22:17:39 +0000 (UTC)
From: "Arpit Agarwal (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12923565.1450733268000.77767.1452550659920@Atlassian.JIRA>
In-Reply-To: <JIRA.12923565.1450733268000@Atlassian.JIRA>
References: <JIRA.12923565.1450733268000@Atlassian.JIRA>
 <JIRA.12923565.1450733268837@arcas>
Subject: [jira] [Commented] (HDFS-9588) DiskBalancer : Add
 submitDiskbalancer RPC
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-9588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092793#comment-15092793 ] 

Arpit Agarwal commented on HDFS-9588:
-------------------------------------

Thanks for the updated patch [~anu]. A few minor comments.

# We can probably remove the result code since lack of an exception is success. We take that approach for other responses in the same protocol.
{code}
message SubmitDiskBalancerPlanResponseProto {
  enum SubmitResults {
    OK = 0;  // Plan accepted
  }
  required SubmitResults result = 1;
{code}
# Nitpick: indentation looks off.
{code}
  /**
 * Submit a disk balancer plan for execution
 */
  rpc submitDiskBalancerPlan(SubmitDiskBalancerPlanRequestProto)
  returns (SubmitDiskBalancerPlanResponseProto);
{code}
# Should this throw IOException instead of Exception?
{code}
  public long submitDiskBalancerPlan(String planID,
      long planVersion, long bandwidth, String plan) throws Exception {
{code}

> DiskBalancer : Add submitDiskbalancer RPC
> -----------------------------------------
>
>                 Key: HDFS-9588
>                 URL: https://issues.apache.org/jira/browse/HDFS-9588
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer & mover
>    Affects Versions: HDFS-1312
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-9588-HDFS-1312.001.patch, HDFS-9588-HDFS-1312.002.patch, HDFS-9588-HDFS-1312.003.patch
>
>
> Add a data node RPC that allows client to submit a diskbalancer plan to data node.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)