Return-Path: 
 <hdfs-issues-return-149688-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 61CA418F58
	for <apmail-hadoop-hdfs-issues-archive@minotaur.apache.org>;
 Tue, 12 Jan 2016 00:34:40 +0000 (UTC)
Received: (qmail 5287 invoked by uid 500); 12 Jan 2016 00:34:40 -0000
Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org
Received: (qmail 5207 invoked by uid 500); 12 Jan 2016 00:34:40 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Reply-To: hdfs-issues@hadoop.apache.org
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 5183 invoked by uid 99); 12 Jan 2016 00:34:39 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jan 2016 00:34:39 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id CA82C2C14F7
	for <hdfs-issues@hadoop.apache.org>; Tue, 12 Jan 2016 00:34:39 +0000 (UTC)
Date: Tue, 12 Jan 2016 00:34:39 +0000 (UTC)
From: "Lei (Eddy) Xu (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12861207.1441163371000.79116.1452558879826@Atlassian.JIRA>
In-Reply-To: <JIRA.12861207.1441163371000@Atlassian.JIRA>
References: <JIRA.12861207.1441163371000@Atlassian.JIRA>
 <JIRA.12861207.1441163371714@arcas>
Subject: [jira] [Commented] (HDFS-9005) Provide support for upgrade domain
 script
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HDFS-9005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093009#comment-15093009 ] 

Lei (Eddy) Xu commented on HDFS-9005:
-------------------------------------

Hi, [~mingma] Thanks a lot for uploading this patch.

I have a few questions regarding the JSON file and the code

* What is the expected format for the JSON file? E.g., it seems that each DN has a separate JSON object? what is the pros and cons comparing putting them into an JSON array? 
* As mentioned previously, it is going to put include/exclude files into "all" file. Do we use different section (keys) to determine the included / excluded DNs or using the {{AdminState}}, it'd be nice to clarify that.
* In {{HostsFileWriter#includeHosts/excludeHost}}, it seems that each function overwrite the whole conf file? Is it a expected behavior?  

A few minor issues:
* There are a few comments that are not jdoc format. 
* Could you add more comments to {{HostConfigManager}}, {{DatanodeAdminProperties}}
* It seems only changed due to space/indent? Could you revert it?
 {code}
      @Override
                public String apply(@Nullable InetSocketAddress addr) {
                  assert addr != null;
                  return addr.getAddress().getHostAddress() + ":" + addr.getPort();
                }
              }));
{code}


* It'd be nice to have a default value here.
 {code}
<property>
2725	  <name>dfs.namenode.hosts.provider.classname</name>
2726	  <value></value>
{code}


Thanks!

> Provide support for upgrade domain script
> -----------------------------------------
>
>                 Key: HDFS-9005
>                 URL: https://issues.apache.org/jira/browse/HDFS-9005
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: HDFS-9005.patch
>
>
> As part of the upgrade domain feature, we need to provide a mechanism to specify upgrade domain for each datanode. One way to accomplish that is to allow admins specify an upgrade domain script that takes DN ip or hostname as input and return the upgrade domain. Then namenode will use it at run time to set {{DatanodeInfo}}'s upgrade domain string. The configuration can be something like:
> {noformat}
> <property>
> <name>dfs.namenode.upgrade.domain.script.file.name</name>
> <value>/etc/hadoop/conf/upgrade-domain.sh</value>
> </property>
> {noformat}
> just like topology script, 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)