hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9706) Log more details in debug logs in BlockReceiver's constructor
Date Wed, 27 Jan 2016 16:33:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119714#comment-15119714

Yongjun Zhang commented on HDFS-9706:

Hi [~xiaochen],

Thanks for working on this. Couple of suggestions:

* Instead of printing {{isTransfer}}, it may be better just to print {{stage}}'s value.
* We are printing almost all parameters except 3 or 4 others. I'd suggest that we take this
opportunity to make a complete printing, and order it as how the parameters are passed to
the method. (that is, one day we may need to know the value of the other parameters when investigating
a new issue), 


> Log more details in debug logs in BlockReceiver's constructor
> -------------------------------------------------------------
>                 Key: HDFS-9706
>                 URL: https://issues.apache.org/jira/browse/HDFS-9706
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>            Priority: Minor
>              Labels: supportability
>         Attachments: HDFS-9706.01.patch
> Currently {{BlockReceiver}}'s constructor has some debug logs to help identifying problems.
During my triage of HDFS-9701, I needed to add the {{isTransfer}} into the logs to see which
block the code goes later.
> I propose to add more details in the debug logs, to save future effort. Will also see
whether more details need to be logged.

This message was sent by Atlassian JIRA

View raw message