hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9654) Code refactoring for HDFS-8578
Date Wed, 27 Jan 2016 07:18:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118784#comment-15118784
] 

Tsz Wo Nicholas Sze commented on HDFS-9654:
-------------------------------------------

> 1. Nit: Params in javadoc do not match the params for the method (i.e. missing config).
 ...

These are not public APIs so that we don't require perfect javadoc.  We usually add javadoc/comment
when the code is tricky.

> 3. Nit: the two checkstyle warnings for number of parameters in doUgrade. ...
> 4. Whitespace issue

We could safely ignore the checkstyle warnings when they are very minor or unreasonable. 


> 5. TestDataNodeVolumeFailure.testUnderReplicationAfterVolFailure test failure. Is this
related?

It does not seem related.  It also failed on some other build such as
- https://builds.apache.org/job/PreCommit-HDFS-Build/14245/testReport/org.apache.hadoop.hdfs.server.datanode/TestDataNodeVolumeFailure/testUnderReplicationAfterVolFailure/

> Code refactoring for HDFS-8578
> ------------------------------
>
>                 Key: HDFS-9654
>                 URL: https://issues.apache.org/jira/browse/HDFS-9654
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Minor
>         Attachments: h9654_20160116.patch
>
>
> This is a code refactoring JIRA in order to change Datanode to process all storage/data
dirs in parallel; see also HDFS-8578.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message