hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Clampffer (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-9627) libhdfs++: Add a mechanism to retrieve human readable error messages through the C API
Date Fri, 08 Jan 2016 19:02:39 GMT

     [ https://issues.apache.org/jira/browse/HDFS-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

James Clampffer updated HDFS-9627:
    Attachment: HDFS-9627.HDFS-8707.001.patch

-renamed headers to avoid conflict, left hdfs_ext in include/libhdfspp for now. [~bobhansen]
please let me know what you think about this.

-test now uses EXPECT_EQ rather than EXPECT_TRUE(foo == bar)

-added LIBHDFS_EXTERNAL modifier to hdfsGetLastError.  hdfs.h explicitly undefs that macro
at the end which is a bit of a bummer.  Copied the definition into hdfs_ext.h and added a
comment explaining.  Still including hdfs.h in case other bits want to use the same typedefs
like hdfsFS, tSize etc.  If the copy/paste of the macro definition looks like a maintenance
issue it might be easier just to strip it out.  It isn't changing anything on unix systems;
not sure if it makes a difference on windows.

-declared hdfsGetLastError as extern "C"

> libhdfs++: Add a mechanism to retrieve human readable error messages through the C API
> --------------------------------------------------------------------------------------
>                 Key: HDFS-9627
>                 URL: https://issues.apache.org/jira/browse/HDFS-9627
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>         Attachments: HDFS-9627.HDFS-8707.000.patch, HDFS-9627.HDFS-8707.000.patch, HDFS-9627.HDFS-8707.001.patch
> Libhdfs doesn't have this but libhdfs3 has a "hdfsGetLastErrorString" function.  The
C API needs to be able to pass out error messages that are more specific than what errno can
> This functionality should be exposed via a new public header in order to keep hdfs.h
consistent with the libhdfs header.

This message was sent by Atlassian JIRA

View raw message