hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6808) Add command line option to ask DataNode reload configuration.
Date Wed, 27 Jan 2016 01:23:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118418#comment-15118418

Arpit Agarwal commented on HDFS-6808:

Hi [~eddyxu], one more question related to reconfiguration (sorry, I am just catching up with
this a year too late for HDFS-9000).

{{ReconfigurationThread#run}} in ReconfigurableBase.java does not update the property in the
cached conf object after invoking {{reconfigurePropertyImpl}} whereas {{ReconfigurableBase#reconfigureProperty}}
does. It looks like the behavior should be consistent across the two.

I think the behavior of {{ReconfigurationThread#run}} as you wrote it is correct. Leaving
the responsibility to the callee avoids [conflicts like this|https://issues.apache.org/jira/browse/HDFS-7035?focusedCommentId=15118395&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15118395].
But it may be an incompatible change so we may have to follow what {{ReconfigurableBase#reconfigureProperty}}
does. What do you think?


> Add command line option to ask DataNode reload configuration.
> -------------------------------------------------------------
>                 Key: HDFS-6808
>                 URL: https://issues.apache.org/jira/browse/HDFS-6808
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: 2.5.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>             Fix For: 2.6.0
>         Attachments: HDFS-6808.000.combo.patch, HDFS-6808.000.patch, HDFS-6808.001.combo.patch,
HDFS-6808.001.patch, HDFS-6808.002.combo.patch, HDFS-6808.002.patch, HDFS-6808.003.combo.txt,
HDFS-6808.003.patch, HDFS-6808.004.combo.patch, HDFS-6808.004.patch, HDFS-6808.005.combo.patch,
HDFS-6808.005.patch, HDFS-6808.006.combo.patch, HDFS-6808.006.patch, HDFS-6808.007.combo.patch,
HDFS-6808.007.patch, HDFS-6808.008.combo.patch, HDFS-6808.008.patch, HDFS-6808.009.combo.patch,
HDFS-6808.009.patch, HDFS-6808.010.patch, HDFS-6808.011.patch
> The workflow of dynamically changing data volumes on DataNode is
> # Users manually changed {{dfs.datanode.data.dir}} in the configuration file
> # User use command line to notify DN to reload configuration and updates its volumes.

> This work adds command line support to notify DN to reload configuration.

This message was sent by Atlassian JIRA

View raw message