Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D00618F1E for ; Wed, 23 Dec 2015 18:58:48 +0000 (UTC) Received: (qmail 48220 invoked by uid 500); 23 Dec 2015 18:58:47 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 48089 invoked by uid 500); 23 Dec 2015 18:58:47 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 47720 invoked by uid 99); 23 Dec 2015 18:58:46 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Dec 2015 18:58:46 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id AD1D72C1F62 for ; Wed, 23 Dec 2015 18:58:46 +0000 (UTC) Date: Wed, 23 Dec 2015 18:58:46 +0000 (UTC) From: "BELUGA BEHR (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-9596) Remove "Shuffle" Method From DFSUtil MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HDFS-9596: ------------------------------ Attachment: Shuffle.HDFS-9596.patch > Remove "Shuffle" Method From DFSUtil > ------------------------------------ > > Key: HDFS-9596 > URL: https://issues.apache.org/jira/browse/HDFS-9596 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 2.7.1 > Reporter: BELUGA BEHR > Priority: Trivial > Attachments: Shuffle.HDFS-9596.patch > > > DFSUtil contains a "shuffle" routine that shuffles arrays. With a little wrapping, Java Collections class can shuffle. This code is superfluous and undocumented. The method returns an array, though it does not specify if it returns the same array or a new, copy, array of shuffled items. > It is only used in one place, so it is better to simply remove and substitute this implementation with the java Collections implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)