Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7FCD81896F for ; Tue, 15 Dec 2015 22:44:47 +0000 (UTC) Received: (qmail 62696 invoked by uid 500); 15 Dec 2015 22:44:47 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 62597 invoked by uid 500); 15 Dec 2015 22:44:47 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 62473 invoked by uid 99); 15 Dec 2015 22:44:47 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2015 22:44:47 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D5C4A2C1F6B for ; Tue, 15 Dec 2015 22:44:46 +0000 (UTC) Date: Tue, 15 Dec 2015 22:44:46 +0000 (UTC) From: "Daryn Sharp (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9557) Reduce object allocation in PB conversion MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059024#comment-15059024 ] Daryn Sharp commented on HDFS-9557: ----------------------------------- Ug, when one last search-n-replace goes horribly wrong... Yes. Will repost. > Reduce object allocation in PB conversion > ----------------------------------------- > > Key: HDFS-9557 > URL: https://issues.apache.org/jira/browse/HDFS-9557 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client > Affects Versions: 2.8.0 > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Attachments: HDFS-9557.patch > > > PB conversions use {{ByteString.copyFrom}} to populate the builder. Unfortunately this creates unique instances for empty arrays instead of returning the singleton {{ByteString.EMPTY}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)