Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD8CC1884E for ; Sat, 5 Dec 2015 02:31:11 +0000 (UTC) Received: (qmail 28496 invoked by uid 500); 5 Dec 2015 02:31:11 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 28438 invoked by uid 500); 5 Dec 2015 02:31:11 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 28270 invoked by uid 99); 5 Dec 2015 02:31:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Dec 2015 02:31:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 142312C1F70 for ; Sat, 5 Dec 2015 02:31:11 +0000 (UTC) Date: Sat, 5 Dec 2015 02:31:11 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9491) Tests should get the number of pending async delets via FsDatasetTestUtils MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042596#comment-15042596 ] Hudson commented on HDFS-9491: ------------------------------ FAILURE: Integrated in Hadoop-trunk-Commit #8927 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8927/]) HDFS-9491. Tests should get the number of pending async deletes via (lei: rev 4265a85f6d9fbf48cdd741bd3d27bfced52f34ca) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/HATestUtil.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetTestUtil.java > Tests should get the number of pending async delets via FsDatasetTestUtils > -------------------------------------------------------------------------- > > Key: HDFS-9491 > URL: https://issues.apache.org/jira/browse/HDFS-9491 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test > Affects Versions: 2.7.1 > Reporter: Tony Wu > Assignee: Tony Wu > Priority: Minor > Fix For: 3.0.0, 2.9.0 > > Attachments: HDFS-9491.001.patch, HDFS-9491.002.patch > > > A few unit tests use {{DataNodeTestUtils#getPendingAsyncDeletions}} to retrieve the number of pending async deletions. It internally calls {{FsDatasetTestUtil#getPendingAsyncDeletions}}: > {code:java} > public static long getPendingAsyncDeletions(FsDatasetSpi fsd) { > return ((FsDatasetImpl)fsd).asyncDiskService.countPendingDeletions(); > } > {code} > This assumes {{FsDatasetImpl}} is (the only implementation of) {{FsDataset}}. However {{FsDataset}} is pluggable and can have other implementations. > We can abstract getting the number of async deletions in {{FsDatasetTestUtils}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)