Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 62AE2175AE for ; Wed, 2 Dec 2015 05:26:12 +0000 (UTC) Received: (qmail 13930 invoked by uid 500); 2 Dec 2015 05:26:11 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 13704 invoked by uid 500); 2 Dec 2015 05:26:11 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 13215 invoked by uid 99); 2 Dec 2015 05:26:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Dec 2015 05:26:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7055B2C1F7C for ; Wed, 2 Dec 2015 05:26:11 +0000 (UTC) Date: Wed, 2 Dec 2015 05:26:11 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-9485) Make BlockManager#removeFromExcessReplicateMap accept BlockInfo instead of Block MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035300#comment-15035300 ] Hudson commented on HDFS-9485: ------------------------------ FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #656 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/656/]) HDFS-9485. Make BlockManager#removeFromExcessReplicateMap accept (jing9: rev 830eb252aaa4fec7ef2ec38cb66f669e8e1ecaa5) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Make BlockManager#removeFromExcessReplicateMap accept BlockInfo instead of Block > -------------------------------------------------------------------------------- > > Key: HDFS-9485 > URL: https://issues.apache.org/jira/browse/HDFS-9485 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-9485.000.patch > > > The {{BlockManager#removeFromExcessReplicateMap()}} method accepts a {{Block}} which is to remove from {{excessReplicateMap}}. However the {{excessReplicateMap}} maps a StorageID to the set of {{BlockInfo}} that are "extra" for the DataNode of the StorageID. Deleting a sub-class object from a collection provided a base-class object happens to work here. > Alternatively, we can make the {{removeFromExcessReplicateMap}} accept a {{BlockInfo}} object. As the current call stack is passing {{BlockInfo}} object mostly, the code change should be safe. -- This message was sent by Atlassian JIRA (v6.3.4#6332)