Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 2 Dec 2015 21:07:11 +0000 (UTC)
From: "Bob Hansen (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12915421.1448297645000.251258.1449090431168@Atlassian.JIRA>
In-Reply-To: <JIRA.12915421.1448297645000@Atlassian.JIRA>
References: <JIRA.12915421.1448297645000@Atlassian.JIRA>
 <JIRA.12915421.1448297645011@arcas>
Subject: [jira] [Commented] (HDFS-9448) Enable valgrind for libhdfspp unit
 tests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036624#comment-15036624 ] 

Bob Hansen commented on HDFS-9448:
----------------------------------

I would very much like [~aw]'s feedback (at least at a high level).

There are three knobs that can be turned here:
* Setting the skip.valgrind.tests for mvn
* Passing in an explicit set of flags through maven to cmake
* If valgrind is not found by cmakes's find_program (which can be passed a hint where to find it using the valgrind_dir cmake property)

If any of the three indicate that we should not run valgrind tests, they are not added to the test suite.  The default is to run the hdfspp unit tests (not integration tests) both with and without valgrind.

Does that seem idiomatically in line with the rest of the Hadoop build infrastructure?

We can open a separate issue to add valgrind to the yetus image.  [~aw] - Should that be an HDFS Jira or a Yetus Jira?

> Enable valgrind for libhdfspp unit tests
> ----------------------------------------
>
>                 Key: HDFS-9448
>                 URL: https://issues.apache.org/jira/browse/HDFS-9448
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Bob Hansen
>            Assignee: Bob Hansen
>         Attachments: HDFS-9448.HDFS-8707.000.patch, HDFS-9448.HDFS-8707.001.patch, HDFS-9448.HDFS-8707.002.patch
>
>
> We should have a target that runs the unit tests under valgrind if it is available on the target machine.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)