Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 61DB318F8D for ; Mon, 14 Dec 2015 19:03:47 +0000 (UTC) Received: (qmail 61261 invoked by uid 500); 14 Dec 2015 19:03:47 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 61111 invoked by uid 500); 14 Dec 2015 19:03:47 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 60967 invoked by uid 99); 14 Dec 2015 19:03:47 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2015 19:03:46 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BEE2B2C1F7C for ; Mon, 14 Dec 2015 19:03:46 +0000 (UTC) Date: Mon, 14 Dec 2015 19:03:46 +0000 (UTC) From: "Lei (Eddy) Xu (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-9281) Change TestDeleteBlockPool to not explicitly use File to check block pool existence. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lei (Eddy) Xu updated HDFS-9281: -------------------------------- Resolution: Fixed Fix Version/s: 2.9.0 3.0.0 Status: Resolved (was: Patch Available) Thanks a lot for the reviews and suggestions, [~cmccabe]! I committed this to {{trunk}} and {{branch-2}}. > Change TestDeleteBlockPool to not explicitly use File to check block pool existence. > ------------------------------------------------------------------------------------ > > Key: HDFS-9281 > URL: https://issues.apache.org/jira/browse/HDFS-9281 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test > Affects Versions: 2.7.1 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Priority: Minor > Fix For: 3.0.0, 2.9.0 > > Attachments: HDFS-9281.00.patch, HDFS-9281.02.patch, HDFS-9281.03.patch, HDFS-9281.combo.00.patch > > > {{TestDeleteBlockPool}} checks the existence of a block pool by checking the directories in the file-based block pool exists. However, it does not apply to non file based fsdataset. > We can fix it by abstracting the checking logic behind {{FsDatasetTestUtils}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)