Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8D07018DF4 for ; Mon, 14 Dec 2015 23:22:51 +0000 (UTC) Received: (qmail 49402 invoked by uid 500); 14 Dec 2015 23:22:47 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 49321 invoked by uid 500); 14 Dec 2015 23:22:47 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 49146 invoked by uid 99); 14 Dec 2015 23:22:47 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2015 23:22:47 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BC44A2C1F7B for ; Mon, 14 Dec 2015 23:22:46 +0000 (UTC) Date: Mon, 14 Dec 2015 23:22:46 +0000 (UTC) From: "Lei (Eddy) Xu (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Reopened] (HDFS-8860) Remove unused Replica copyOnWrite code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lei (Eddy) Xu reopened HDFS-8860: --------------------------------- > Remove unused Replica copyOnWrite code > -------------------------------------- > > Key: HDFS-8860 > URL: https://issues.apache.org/jira/browse/HDFS-8860 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 3.0.0, 2.8.0 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Fix For: 2.8.0 > > Attachments: HDFS-8860.0.patch > > > {{ReplicaInfo#unlinkBlock()}} is effectively disabled by the following code, because {{isUnlinked()}} always returns true. > {code} > if (isUnlinked()) { > return false; > } > {code} > Several test cases, e.g., {{TestFileAppend#testCopyOnWrite}} and {{TestDatanodeRestart#testRecoverReplicas}} are testing against the unlink > Lets remove the relevant code to eliminate the confusions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)