hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9569) Log the name of the fsimage being loaded for better supportability
Date Mon, 21 Dec 2015 17:40:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066766#comment-15066766
] 

Chris Nauroth commented on HDFS-9569:
-------------------------------------

OK, let's go with the rev 4 approach.  However, I don't understand why this was added:

{code}
     List<FSImageFile> imageFiles = inspector.getLatestImages();
-
+    if (imageFiles.size() == 0) {
+      throw new IOException("Failed to find any FSImage files.");
+    }
+    
{code}

I think this is unreachable code.  The implementations of {{getLatestImages}} are written
to either return a non-empty list or throw an exception, so it appears to be impossible for
the list to be empty by the time execution reaches here.

> Log the name of the fsimage being loaded for better supportability
> ------------------------------------------------------------------
>
>                 Key: HDFS-9569
>                 URL: https://issues.apache.org/jira/browse/HDFS-9569
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>            Priority: Trivial
>              Labels: supportability
>             Fix For: 2.7.3
>
>         Attachments: HDFS-9569.001.patch, HDFS-9569.002.patch, HDFS-9569.003.patch, HDFS-9569.004.patch
>
>
> When NN starts to load fsimage, it does
> {code}
>  void loadFSImageFile(FSNamesystem target, MetaRecoveryContext recovery,
>       FSImageFile imageFile, StartupOption startupOption) throws IOException {
>       LOG.debug("Planning to load image :\n" + imageFile);
>       ......
>     long txId = loader.getLoadedImageTxId();
>     LOG.info("Loaded image for txid " + txId + " from " + curFile);
> {code}
> A debug msg is issued at the beginning with the fsimage file name, then at the end an
info msg is issued after loading.
> If the fsimage loading failed due to corrupted fsimage (see HDFS-9406), we don't see
the first msg. It'd be helpful to always be able to see from NN logs what fsimage file it's
loading.
> Two improvements:
> 1. Change the above debug to info
> 2. If exception happens when loading fsimage, be sure to report the fsimage name being
loaded in the error message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message