hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-9569) Log the name of the fsimage being loaded for better supportability
Date Thu, 17 Dec 2015 02:42:46 GMT

     [ https://issues.apache.org/jira/browse/HDFS-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yongjun Zhang updated HDFS-9569:
--------------------------------
    Description: 
When NN starts to load fsimage, it does

{code}
 void loadFSImageFile(FSNamesystem target, MetaRecoveryContext recovery,
      FSImageFile imageFile, StartupOption startupOption) throws IOException {
      LOG.debug("Planning to load image :\n" + imageFile);
      ......
    long txId = loader.getLoadedImageTxId();
    LOG.info("Loaded image for txid " + txId + " from " + curFile);
{code}

A debug msg is issued at the beginning with the fsimage file name, then at the end an info
msg is issued after loading.

If the fsimage loading failed due to corrupted fsimage (see HDFS-9406), we don't see the first
msg. It'd be helpful to always be able to see from NN logs what fsimage file it's loading.

Two improvements:

1. Change the above debug to info
2. If exception happens when loading fsimage, be sure to report the fsimage name being loaded
in the error message.


  was:
When NN starts to load fsimage, it does

{code}
 void loadFSImageFile(FSNamesystem target, MetaRecoveryContext recovery,
      FSImageFile imageFile, StartupOption startupOption) throws IOException {
      LOG.debug("Planning to load image :\n" + imageFile);
      ......
    long txId = loader.getLoadedImageTxId();
    LOG.info("Loaded image for txid " + txId + " from " + curFile);
{code}

A debug msg is issued at the beginning with the fsimage file name, then at the end an info
msg is issued after loading.

If the fsimage loading failed due to corrupted fsimage, we don't see the first msg. It'd be
helpful to always be able to see from NN logs what fsimage file it's loading.

Creating this jira to change the debug to info.

{code}


        Summary: Log the name of the fsimage being loaded for better supportability  (was:
Change msg issused before loading fsimage to Info from debug for better supportability)

> Log the name of the fsimage being loaded for better supportability
> ------------------------------------------------------------------
>
>                 Key: HDFS-9569
>                 URL: https://issues.apache.org/jira/browse/HDFS-9569
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>            Priority: Trivial
>
> When NN starts to load fsimage, it does
> {code}
>  void loadFSImageFile(FSNamesystem target, MetaRecoveryContext recovery,
>       FSImageFile imageFile, StartupOption startupOption) throws IOException {
>       LOG.debug("Planning to load image :\n" + imageFile);
>       ......
>     long txId = loader.getLoadedImageTxId();
>     LOG.info("Loaded image for txid " + txId + " from " + curFile);
> {code}
> A debug msg is issued at the beginning with the fsimage file name, then at the end an
info msg is issued after loading.
> If the fsimage loading failed due to corrupted fsimage (see HDFS-9406), we don't see
the first msg. It'd be helpful to always be able to see from NN logs what fsimage file it's
loading.
> Two improvements:
> 1. Change the above debug to info
> 2. If exception happens when loading fsimage, be sure to report the fsimage name being
loaded in the error message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message