hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-9557) Reduce object allocation in PB conversion
Date Wed, 16 Dec 2015 19:18:47 GMT

     [ https://issues.apache.org/jira/browse/HDFS-9557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Nauroth updated HDFS-9557:
--------------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 2.8.0
           Status: Resolved  (was: Patch Available)

I took a closer look, and those tests are very unpredictable, with or without this patch.
 sigh

+1, and committed to trunk, branch-2 and branch-2.8.  Thank you, Daryn.

> Reduce object allocation in PB conversion
> -----------------------------------------
>
>                 Key: HDFS-9557
>                 URL: https://issues.apache.org/jira/browse/HDFS-9557
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.8.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9557.patch, HDFS-9557.patch
>
>
> PB conversions use {{ByteString.copyFrom}} to populate the builder.  Unfortunately this
creates unique instances for empty arrays instead of returning the singleton {{ByteString.EMPTY}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message