hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9557) Reduce object allocation in PB conversion
Date Wed, 16 Dec 2015 05:19:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059508#comment-15059508
] 

Chris Nauroth commented on HDFS-9557:
-------------------------------------

Daryn, could you please review the test failures?  I quickly ruled out the javac and Checkstyle
warnings.  They appear to be unrelated/unaddressable within the scope of this patch.

> Reduce object allocation in PB conversion
> -----------------------------------------
>
>                 Key: HDFS-9557
>                 URL: https://issues.apache.org/jira/browse/HDFS-9557
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.8.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-9557.patch, HDFS-9557.patch
>
>
> PB conversions use {{ByteString.copyFrom}} to populate the builder.  Unfortunately this
creates unique instances for empty arrays instead of returning the singleton {{ByteString.EMPTY}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message