hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9527) The return type of FSNamesystem.getBlockCollection should be changed to INodeFile
Date Thu, 10 Dec 2015 00:38:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049734#comment-15049734
] 

Jing Zhao commented on HDFS-9527:
---------------------------------

The new patch looks good to me. The failed tests should be unrelated. +1

The failed {{TestReplication#testNoExtraReplicationWhenBlockReceivedIsLate}} seems flaky.
We can fix it in a separate jira.



> The return type of FSNamesystem.getBlockCollection should be changed to INodeFile
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-9527
>                 URL: https://issues.apache.org/jira/browse/HDFS-9527
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Minor
>         Attachments: h9527_20151208.patch, h9527_20151209.patch
>
>
> FSNamesystem.getBlockCollection always returns INodeFile.  It avoids unnecessary conversion
from BlockCollection to INode/INodeFile after the change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message