hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Clampffer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9524) libhdfs++ deadlocks in Filesystem::New if NN conneciton fails
Date Wed, 16 Dec 2015 15:54:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060192#comment-15060192
] 

James Clampffer commented on HDFS-9524:
---------------------------------------

"That's a good suggestion. I added comments to the public interface. I also spent some time
thinking about how I would want to respond at run-time to detecting the error, and the current
default behavior of dump core for easy debugging and terminate the app is probably the best
one. I added some output to stderr to make it even more explicit what the error case is."
The added warning looks good.  The check for thread self joins should save huge amounts of
debugging time for anyone who may hit this in the future.  I agree with doing a core dump,
I can't think of a good way to recover cleanly from that; better to just fix the client application.

+1, will commit shortly.

> libhdfs++ deadlocks in Filesystem::New if NN conneciton fails
> -------------------------------------------------------------
>
>                 Key: HDFS-9524
>                 URL: https://issues.apache.org/jira/browse/HDFS-9524
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Bob Hansen
>            Assignee: Bob Hansen
>         Attachments: HDFS-9524.HDFS-8707.000.patch, HDFS-9524.HDFS-8707.001.patch, HDFS-9524.HDFS-8707.002.patch
>
>
> FileSystem::New attempts to free the new FileSystem if the connection fails.  Unfortunately,
it's in the middle of a callback from the filesystem's threadpool, and attempts to join the
worker thread while running the worker thread.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message