hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9519) Some coding improvement in SecondaryNameNode#main
Date Sat, 12 Dec 2015 10:44:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054223#comment-15054223
] 

Hudson commented on HDFS-9519:
------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #690 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/690/])
HDFS-9519. Some coding improvement in SecondaryNameNode#main. (Xiao Chen (yzhang: rev 2a4c7d4facabb8b99d6dcbf4ccfe2afedf4fd445)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java


> Some coding improvement in SecondaryNameNode#main
> -------------------------------------------------
>
>                 Key: HDFS-9519
>                 URL: https://issues.apache.org/jira/browse/HDFS-9519
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Yongjun Zhang
>            Assignee: Xiao Chen
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9519.01.patch, HDFS-9519.02.patch
>
>
> Two nits:
> # The checking whether secondary is null is not necessary in the following code in SecondaryNameNode.java.

> # The comment in this code seems to imply that "when secondary is not null, SNN was stared
as a daemon.", and this is not true. Suggest to improve the comment to make it clear,
> Assign to Xiao since he worked on HDFS-3059. Thanks Xiao.
> {code}
>       if (secondary != null) {
>         // The web server is only needed when starting SNN as a daemon,
>         // and not needed if called from shell command. Starting the web server
>         // from shell may fail when getting credentials, if the environment
>         // is not set up for it, which is most of the case.
>         secondary.startInfoServer();
>         secondary.startCheckpointThread();
>         secondary.join();
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message