hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9519) Some coding improvement in SecondaryNameNode#main
Date Tue, 08 Dec 2015 04:00:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046309#comment-15046309

Allen Wittenauer commented on HDFS-9519:

If the secondary namenode isn't actually configured but someone tries to start the 2nn, what
happens?  Also, does Checkpoint and Backup have different entry points or is this used for
those too?

> Some coding improvement in SecondaryNameNode#main
> -------------------------------------------------
>                 Key: HDFS-9519
>                 URL: https://issues.apache.org/jira/browse/HDFS-9519
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Yongjun Zhang
>            Assignee: Xiao Chen
> Two nits:
> # The checking whether secondary is null is not necessary in the following code in SecondaryNameNode.java.

> # The comment in this code seems to imply that "when secondary is not null, SNN was stared
as a daemon.", and this is not true. Suggest to improve the comment to make it clear,
> Assign to Xiao since he worked on HDFS-3059. Thanks Xiao.
> {code}
>       if (secondary != null) {
>         // The web server is only needed when starting SNN as a daemon,
>         // and not needed if called from shell command. Starting the web server
>         // from shell may fail when getting credentials, if the environment
>         // is not set up for it, which is most of the case.
>         secondary.startInfoServer();
>         secondary.startCheckpointThread();
>         secondary.join();
>       }
> {code}

This message was sent by Atlassian JIRA

View raw message