hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9498) Move code that tracks orphan blocks to BlockManagerSafeMode
Date Sat, 19 Dec 2015 00:10:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065029#comment-15065029
] 

Anu Engineer commented on HDFS-9498:
------------------------------------

[~liuml07] Thanks for updating the patch so quickly. 

I have a question - In the older code we were checking for an orphan block if and only if
we were in StartupSafeMode,  but with the function {{BlockManagerSafeMode#checkOrphanBlock}}
we seem to check for these blocks under more conditions. To map to the new semantics, shouldn't
we check against
BMSafeModeStatus.PENDING_THRESHOLD  instead of  BMSafeModeStatus.OFF ?, rest of the changes
look good to me.


> Move code that tracks orphan blocks to BlockManagerSafeMode
> -----------------------------------------------------------
>
>                 Key: HDFS-9498
>                 URL: https://issues.apache.org/jira/browse/HDFS-9498
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HDFS-9498.000.patch, HDFS-9498.001.patch, HDFS-9498.002.patch, HDFS-9498.003.patch
>
>
> [HDFS-4015] counts and reports orphaned blocks  {{numberOfBytesInFutureBlocks}} in safe
mode. It was implemented in {{BlockManager}}. Per discussion in [HDFS-9129] which introduces
the {{BlockManagerSafeMode}}, we can move code that maintaining orphaned blocks to this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message