hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lei (Eddy) Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9493) Test o.a.h.hdfs.server.namenode.TestMetaSave fails in trunk
Date Fri, 18 Dec 2015 19:30:47 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064576#comment-15064576
] 

Lei (Eddy) Xu commented on HDFS-9493:
-------------------------------------

Hi, [~twu]

Thanks a lot for addressing this failure.  The overall idea looks very good. Will +1 once
address the following comments

* In {{isDatanodeRemoved}}, you don't need to hold {{FSNamesystem}}'s read lock.  {{NetworkTopology#contains}}
holds its own read lock.
* Would you mind to rename {{stopDnAndWaitForNnToRemoveIt()}} to something like {{stopDatanodeAndWait}}?
Using {{Dn}} {{Nn}} is a little bit hard to read.
* You might want to consider to set {{dfs.namenode.stale.datanode.interval}} to a smaller
value.

> Test o.a.h.hdfs.server.namenode.TestMetaSave fails in trunk
> -----------------------------------------------------------
>
>                 Key: HDFS-9493
>                 URL: https://issues.apache.org/jira/browse/HDFS-9493
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Mingliang Liu
>            Assignee: Tony Wu
>         Attachments: HDFS-9493.001.patch, HDFS-9493.002.patch
>
>
> Tested in both Gentoo Linux and Mac.
> {quote}
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hdfs.server.namenode.TestMetaSave
> Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 34.159 sec <<<
FAILURE! - in org.apache.hadoop.hdfs.server.namenode.TestMetaSave
> testMetasaveAfterDelete(org.apache.hadoop.hdfs.server.namenode.TestMetaSave)  Time elapsed:
15.318 sec  <<< FAILURE!
> java.lang.AssertionError: null
> 	at org.junit.Assert.fail(Assert.java:86)
> 	at org.junit.Assert.assertTrue(Assert.java:41)
> 	at org.junit.Assert.assertTrue(Assert.java:52)
> 	at org.apache.hadoop.hdfs.server.namenode.TestMetaSave.testMetasaveAfterDelete(TestMetaSave.java:154)
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message