hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9491) Tests should get the number of pending async delets via FsDatasetTestUtils
Date Sat, 05 Dec 2015 02:31:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042596#comment-15042596
] 

Hudson commented on HDFS-9491:
------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #8927 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8927/])
HDFS-9491. Tests should get the number of pending async deletes via (lei: rev 4265a85f6d9fbf48cdd741bd3d27bfced52f34ca)
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/HATestUtil.java
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetTestUtil.java


> Tests should get the number of pending async delets via FsDatasetTestUtils
> --------------------------------------------------------------------------
>
>                 Key: HDFS-9491
>                 URL: https://issues.apache.org/jira/browse/HDFS-9491
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.7.1
>            Reporter: Tony Wu
>            Assignee: Tony Wu
>            Priority: Minor
>             Fix For: 3.0.0, 2.9.0
>
>         Attachments: HDFS-9491.001.patch, HDFS-9491.002.patch
>
>
> A few unit tests use {{DataNodeTestUtils#getPendingAsyncDeletions}} to retrieve the number
of pending async deletions. It internally calls {{FsDatasetTestUtil#getPendingAsyncDeletions}}:
> {code:java}
> public static long getPendingAsyncDeletions(FsDatasetSpi<?> fsd) {
>     return ((FsDatasetImpl)fsd).asyncDiskService.countPendingDeletions();
> }
> {code}
> This assumes {{FsDatasetImpl}} is (the only implementation of) {{FsDataset}}. However
{{FsDataset}} is pluggable and can have other implementations.
> We can abstract getting the number of async deletions in {{FsDatasetTestUtils}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message