hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lei (Eddy) Xu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-9491) Tests should get the number of pending async delets via FsDatasetTestUtils
Date Sat, 05 Dec 2015 02:08:11 GMT

     [ https://issues.apache.org/jira/browse/HDFS-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lei (Eddy) Xu updated HDFS-9491:
--------------------------------
       Resolution: Fixed
    Fix Version/s: 2.9.0
                   3.0.0
           Status: Resolved  (was: Patch Available)

+1. I ran related tests locally without errors. 

Thanks very much, [~twu]. 

> Tests should get the number of pending async delets via FsDatasetTestUtils
> --------------------------------------------------------------------------
>
>                 Key: HDFS-9491
>                 URL: https://issues.apache.org/jira/browse/HDFS-9491
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.7.1
>            Reporter: Tony Wu
>            Assignee: Tony Wu
>            Priority: Minor
>             Fix For: 3.0.0, 2.9.0
>
>         Attachments: HDFS-9491.001.patch, HDFS-9491.002.patch
>
>
> A few unit tests use {{DataNodeTestUtils#getPendingAsyncDeletions}} to retrieve the number
of pending async deletions. It internally calls {{FsDatasetTestUtil#getPendingAsyncDeletions}}:
> {code:java}
> public static long getPendingAsyncDeletions(FsDatasetSpi<?> fsd) {
>     return ((FsDatasetImpl)fsd).asyncDiskService.countPendingDeletions();
> }
> {code}
> This assumes {{FsDatasetImpl}} is (the only implementation of) {{FsDataset}}. However
{{FsDataset}} is pluggable and can have other implementations.
> We can abstract getting the number of async deletions in {{FsDatasetTestUtils}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message