hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lei (Eddy) Xu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9490) MiniDFSCluster should change block generation stamp via FsDatasetTestUtils
Date Wed, 02 Dec 2015 02:28:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035145#comment-15035145
] 

Lei (Eddy) Xu commented on HDFS-9490:
-------------------------------------

Hi, [~twu] Thanks for working on this.

Could you change {{changeStoredGenerationStamp}} to be {{void}} and just throw {{IOException}}
for errors. It is more consistent with {{MaterialziedReplica}}. You can use {{Files#move()}}
in this case.

The rest LGTM. Will +1 once address the comments.


> MiniDFSCluster should change block generation stamp via FsDatasetTestUtils
> --------------------------------------------------------------------------
>
>                 Key: HDFS-9490
>                 URL: https://issues.apache.org/jira/browse/HDFS-9490
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.7.1
>            Reporter: Tony Wu
>            Assignee: Tony Wu
>            Priority: Minor
>         Attachments: HDFS-9490.001.patch
>
>
> {{MiniDFSCluster#changeGenStampOfBlock}} directly manipulates the block meta file to
update the generation stamp. This depends on file based {{FsDataset}}.
> We can abstract the change generation stamp operation in {{FsDatasetTestUtils}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message