hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9484) NNThroughputBenchmark$BlockReportStats should not send empty block reports
Date Thu, 03 Dec 2015 19:05:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038347#comment-15038347

Konstantin Shvachko commented on HDFS-9484:

Will commit both shortly.

> NNThroughputBenchmark$BlockReportStats should not send empty block reports
> --------------------------------------------------------------------------
>                 Key: HDFS-9484
>                 URL: https://issues.apache.org/jira/browse/HDFS-9484
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HDFS-9484.000.patch, HDFS-9484.001.patch
> There are two potential bugs that make the {{NNThroughputBenchmark$BlockReportStats}}
send empty block reports.
> # In {{NNThroughputBenchmark$BlockReportStats#formBlockReport()}}, the {{blockReportList}}
is always {{BlockListAsLongs.EMPTY}}. We should construct the block report list by encoding
generated {{blocks}} in test.
> # {{TinyDatanode#blocks}} is an empty ArrayList with initial capacity. In {{TinyDatanode#addBlock()}}
first statement, the {{if(nrBlocks == blocks.size()) {}} will always be true. We should either
fill the blocks with dummy report in {{TinyDatanode()}} constructor, or use initial capacity
instead of {{blocks.size()}} in the above _if_ statement (we should replace {{ArrayList#set}}
with {{ArrayList#add}} as well).

This message was sent by Atlassian JIRA

View raw message