hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9448) Enable valgrind for libhdfspp unit tests
Date Thu, 03 Dec 2015 03:32:10 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037181#comment-15037181
] 

Allen Wittenauer commented on HDFS-9448:
----------------------------------------

bq. Does that seem idiomatically in line with the rest of the Hadoop build infrastructure?

It sort of feels backwards, in a way.  But I'm hoping to get a chance to play with it more
tomorrow.

bq. We can open a separate issue to add valgrind to the yetus image. Allen Wittenauer - Should
that be an HDFS Jira or a Yetus Jira?

This tells me that I've failed to communicate. :(  So let's try it one more time.

I'm developing a patch for Hadoop.  Let's say I do it on a Mac. I do a build and everything
seems ok, but I know I don't have a working libzip2.   I can run the ./start-build-env.sh
script that is in the root of the source tree.  It will fire off Docker and create a working
Linux environment that has *everything* I need to get the *full* capabilities of the Hadoop
build, including any requirements of *all* of the unit tests.

Now ask yourself, if a test gets added that needs valgrind, should it be part of the Dockerfile
that ships with Hadoop?

> Enable valgrind for libhdfspp unit tests
> ----------------------------------------
>
>                 Key: HDFS-9448
>                 URL: https://issues.apache.org/jira/browse/HDFS-9448
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Bob Hansen
>            Assignee: Bob Hansen
>         Attachments: HDFS-9448.HDFS-8707.000.patch, HDFS-9448.HDFS-8707.001.patch, HDFS-9448.HDFS-8707.002.patch
>
>
> We should have a target that runs the unit tests under valgrind if it is available on
the target machine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message