hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9347) Invariant assumption in TestQuorumJournalManager.shutdown() is wrong
Date Sat, 19 Dec 2015 00:50:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065086#comment-15065086
] 

Hudson commented on HDFS-9347:
------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #9001 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9001/])
HDFS-9347. Invariant assumption in TestQuorumJournalManager.shutdown() (zhz: rev ef3f3f6bb14cf44bef1778f1091d8ed8a4b764a3)
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java
* hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> Invariant assumption in TestQuorumJournalManager.shutdown() is wrong
> --------------------------------------------------------------------
>
>                 Key: HDFS-9347
>                 URL: https://issues.apache.org/jira/browse/HDFS-9347
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9347.001.patch, HDFS-9347.002.patch, HDFS-9347.003.patch, HDFS-9347.004.patch,
HDFS-9347.005.patch, HDFS-9347.006.patch
>
>
> The code
> {code:title=TestTestQuorumJournalManager.java|borderStyle=solid}
> @After
>   public void shutdown() throws IOException {
>     IOUtils.cleanup(LOG, toClose.toArray(new Closeable[0]));
>     
>     // Should not leak clients between tests -- this can cause flaky tests.
>     // (See HDFS-4643)
>     GenericTestUtils.assertNoThreadsMatching(".*IPC Client.*");
>     
>     if (cluster != null) {
>       cluster.shutdown();
>     }
>   }
> {code}
> implicitly assumes when the call returns from IOUtils.cleanup() (which calls close()
on QuorumJournalManager object), all IPC client connection threads are terminated. However,
there is no internal implementation that enforces this assumption. Even if the bug reported
in HADOOP-12532 is fixed, the internal code still only ensures IPC connections are terminated,
but not the thread.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message