hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-9262) Reconfigure DN lazy writer interval on the fly
Date Fri, 04 Dec 2015 22:36:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042347#comment-15042347
] 

Arpit Agarwal edited comment on HDFS-9262 at 12/4/15 10:35 PM:
---------------------------------------------------------------

Hi [~xiaobingo], we already have a cross-cast to Reconfigurable. Instead I think a downcast
to FsDatasetImpl will be easier to follow and we can remove the unused functions from FsDatasetImpl.

Alternatively, FsDatasetSpi can extend {{Reconfigurable}} and DN delegates all 'unknown' properties
to the dataset. Then we don't need any downcasts or reflection. You can also avoid hard-coding
DFS_DATANODE_LAZY_WRITER_INTERVAL_SEC in DataNode#RECONFIGURABLE_PROPERTIES, querying the
list from the dataset and appending it to #RECONFIGURABLE_PROPERTIES. This is better long
term but I am fine with either.

The same applies to HDFS-9330.


was (Author: arpitagarwal):
Hi [~xiaobingo], we already have a cross-cast to Reconfigurable. Instead I think a downcast
to FsDatasetImpl will be easier to follow and we can remove the unused functions from FsDatasetImpl.

Alternatively, FsDatasetSpi can extend {{Reconfigurable}} and DN delegates all 'unknown' properties
to the dataset. Then we don't need any downcasts or reflection. You can also avoid hard-coding
DFS_DATANODE_LAZY_WRITER_INTERVAL_SEC in DataNode#RECONFIGURABLE_PROPERTIES, querying the
list from the dataset and appending it to #RECONFIGURABLE_PROPERTIES. This is better long
term but I am fine with either.

> Reconfigure DN lazy writer interval on the fly
> ----------------------------------------------
>
>                 Key: HDFS-9262
>                 URL: https://issues.apache.org/jira/browse/HDFS-9262
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: 2.7.0
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-9262.001.patch
>
>
> This is to reconfigure
> {code}
> dfs.datanode.lazywriter.interval.sec
> {code}
> without restarting DN.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message