hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-9094) Add command line option to ask NameNode reload configuration.
Date Thu, 24 Dec 2015 01:11:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070362#comment-15070362
] 

Arpit Agarwal edited comment on HDFS-9094 at 12/24/15 1:11 AM:
---------------------------------------------------------------

Hi [~xiaobingo], thanks for the updated patch. My comments below:

# There is no need to add the reconfig methods to ClientNameNodeProtocol since we have ReconfigurationProtocol.
# NameNodeProtocols should extend ReconfigurationProtocol now. You will also need to add the
protocol translator when starting the client RPC and service RPC ports (I would recommend
adding the protocol to both ports so the command can be issued on one if the other is non-responsive).
# The {{<datanode|namenode>}} parameter to {{dfsadmin -reconfig}} is no longer needed.
The new command syntax should be just {{dfsadmin -reconfig host:port ...}}, instantiating
a ReconfigurationProtocol proxy instead of NN/DN-specific proxy.
# We do have to support {{dfsadmin -reconfig datanode host:port}} for compatibility. If the
{{datanode}} parameter is given then {{DFSAdmin#startReconfiguration}} etc. can continue to
instantiate ClientDatanodeProtocol proxy explicitly since the target DN may be an older version
and not support ReconfigurationProtocol.


was (Author: arpitagarwal):
Hi [~xiaobingo], thanks for the updated patch. My comments below:

# There is no need to reconfig methods to ClientNameNodeProtocol since we have ReconfigurationProtocol.
# NameNodeProtocols should extend ReconfigurationProtocol now. You will also need to add the
protocol translator when starting the client RPC and service RPC ports (I would recommend
adding the protocol to both ports so the command can be issued on one if the other is non-responsive).
# The {{<datanode|namenode>}} parameter to {{dfsadmin -reconfig}} is no longer needed.
The new command syntax should be just {{dfsadmin -reconfig host:port ...}}, instantiating
a ReconfigurationProtocol proxy instead of NN/DN-specific proxy.
# We do have to support {{dfsadmin -reconfig datanode host:port}} for compatibility. If the
{{datanode}} parameter is given then {{DFSAdmin#startReconfiguration}} etc. can continue to
instantiate ClientDatanodeProtocol proxy explicitly since the target DN may be an older version
and not support ReconfigurationProtocol.

> Add command line option to ask NameNode reload configuration.
> -------------------------------------------------------------
>
>                 Key: HDFS-9094
>                 URL: https://issues.apache.org/jira/browse/HDFS-9094
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 2.7.0
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-9094-HDFS-9000.002.patch, HDFS-9094-HDFS-9000.003.patch, HDFS-9094.001.patch
>
>
> This work is going to add DFS admin command that allows reloading NameNode configuration.
This is sibling work related to HDFS-6808.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message