hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8836) Skip newline on empty files with getMerge -nl
Date Fri, 11 Dec 2015 07:06:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052315#comment-15052315
] 

Akira AJISAKA commented on HDFS-8836:
-------------------------------------

Thank you for your comment.

bq. I think private and accessors are not required for skipEmptyFileDelimiter as this variable
required to be accessed only in this or a subclass.
I'm thinking the variable should be private because the methods of {{Merge}} are not likely
to be overridden.

> Skip newline on empty files with getMerge -nl
> ---------------------------------------------
>
>                 Key: HDFS-8836
>                 URL: https://issues.apache.org/jira/browse/HDFS-8836
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.6.0, 2.7.1
>            Reporter: Jan Filipiak
>            Assignee: Kanaka Kumar Avvaru
>            Priority: Trivial
>         Attachments: HDFS-8836-01.patch, HDFS-8836-02.patch, HDFS-8836-03.patch, HDFS-8836-04.patch,
HDFS-8836-05.patch, HDFS-8836-06.patch
>
>
> Hello everyone,
> I recently was in the need of using the new line option -nl with getMerge because the
files I needed to merge simply didn't had one. I was merging all the files from one directory
and unfortunately this directory also included empty files, which effectively led to multiple
newlines append after some files. I needed to remove them manually afterwards.
> In this situation it is maybe good to have another argument that allows skipping empty
files.
> Thing one could try to implement this feature:
> The call for IOUtils.copyBytes(in, out, getConf(), false); doesn't
> return the number of bytes copied which would be convenient as one could
> skip append the new line when 0 bytes where copied or one would check the file size before.
> I posted this Idea on the mailing list http://mail-archives.apache.org/mod_mbox/hadoop-user/201507.mbox/%3C55B25140.3060005%40trivago.com%3E
but I didn't really get many responses, so I thought I my try this way.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message