hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7553) fix the TestDFSUpgradeWithHA due to BindException
Date Mon, 21 Dec 2015 22:45:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067195#comment-15067195

Chris Nauroth commented on HDFS-7553:

[~xiaochen], thank you for picking this up.

Seeing the change now, I'm hesitant to commit the {{join}} call in {{NameNode}}.  As you said,
it could change shutdown behavior and introduce a slowdown or a hang.  The need to {{join}}
is an artificial requirement of the tests.  In real production usage, this would rely on process
shutdown at the OS level.

Instead, maybe we could approach this as more of a test-only change.  We could add a {{NameNode#getHttpServer}}
method, annotated {{VisibleForTesting}}.  Then, {{MiniDFSCluster#shutdown}} and {{MiniDFSCluster#shutdownNameNode}}
could be changed to call that method after the current NameNode shutdown logic, and then call
{{NameNodeHttpServer#join}}.  This would help with shutdown for tests, but it would leave
the main shutdown sequence unaltered.

Let me know your thoughts.

> fix the TestDFSUpgradeWithHA due to BindException
> -------------------------------------------------
>                 Key: HDFS-7553
>                 URL: https://issues.apache.org/jira/browse/HDFS-7553
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: 2.7.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>              Labels: BB2015-05-TBR
>         Attachments: HDFS-7553-001.txt, HDFS-7553.002.patch, HDFS-7553.repro.patch
> see https://builds.apache.org/job/PreCommit-HDFS-Build/9092//testReport/org.apache.hadoop.hdfs.server.namenode.ha/TestDFSUpgradeWithHA/testNfsUpgrade/
> Error Message
> Port in use: localhost:57896
> Stacktrace
> java.net.BindException: Port in use: localhost:57896
> 	at sun.nio.ch.Net.bind0(Native Method)
> 	at sun.nio.ch.Net.bind(Net.java:444)
> 	at sun.nio.ch.Net.bind(Net.java:436)
> 	at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:214)
> 	at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
> 	at org.mortbay.jetty.nio.SelectChannelConnector.open(SelectChannelConnector.java:216)
> 	at org.apache.hadoop.http.HttpServer2.openListeners(HttpServer2.java:868)
> 	at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:809)
> 	at org.apache.hadoop.hdfs.server.namenode.NameNodeHttpServer.start(NameNodeHttpServer.java:142)
> 	at org.apache.hadoop.hdfs.server.namenode.NameNode.startHttpServer(NameNode.java:704)
> 	at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:591)
> 	at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:763)
> 	at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:747)
> 	at org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1443)
> 	at org.apache.hadoop.hdfs.MiniDFSCluster.restartNameNode(MiniDFSCluster.java:1815)
> 	at org.apache.hadoop.hdfs.MiniDFSCluster.restartNameNode(MiniDFSCluster.java:1796)
> 	at org.apache.hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA.testNfsUpgrade(TestDFSUpgradeWithHA.java:285)

This message was sent by Atlassian JIRA

View raw message