Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 5 Nov 2015 20:33:27 +0000 (UTC)
From: "Bob Hansen (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12908668.1446059041000.166879.1446755607802@Atlassian.JIRA>
In-Reply-To: <JIRA.12908668.1446059041000@Atlassian.JIRA>
References: <JIRA.12908668.1446059041000@Atlassian.JIRA>
 <JIRA.12908668.1446059041635@arcas>
Subject: [jira] [Commented] (HDFS-9328) Formalize coding standards for
 libhdfs++ and put them in a README.txt
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992415#comment-14992415 ] 

Bob Hansen commented on HDFS-9328:
----------------------------------

I am not keen on tying the coding standards to a tool such as clang-format.  That can be a handy tool in applying the rest of the standards, but doesn't actually specify what the standards should be.  I would remove (1) completely, and specify any deltas from the google standards that we expect to be enforced.

Adding an if/else example to (2) for extra clarity would be a Good Thing.


> Formalize coding standards for libhdfs++ and put them in a README.txt
> ---------------------------------------------------------------------
>
>                 Key: HDFS-9328
>                 URL: https://issues.apache.org/jira/browse/HDFS-9328
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>            Priority: Blocker
>         Attachments: HDFS-9328.HDFS-8707.000.patch
>
>
> We have 2-3 people working on this project full time and hopefully more people will start contributing.  In order to efficiently scale we need a single, easy to find, place where developers can check to make sure they are following the coding standards of this project to both save their time and save the time of people doing code reviews.
> The most practical place to do this seems like a README file in libhdfspp/. 
> The foundation of the standards is google's C++ guide found here: https://google-styleguide.googlecode.com/svn/trunk/cppguide.html
> Any exceptions to google's standards or additional restrictions need to be explicitly enumerated so there is one single point of reference for all libhdfs++ code standards.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)