hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anu Engineer (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-9449) DiskBalancer : Add connectors
Date Tue, 01 Dec 2015 00:03:11 GMT

     [ https://issues.apache.org/jira/browse/HDFS-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Anu Engineer updated HDFS-9449:
-------------------------------
    Attachment: HDFS-9449-HDFS-1312.003.patch

Thank for the review [~szetszwo]. I have addressed all your comments

bq. DBNameNodeConnector.connector should final. Then, it will never null so that we don't
need to check null for it.
fixed.

bq. DBNameNodeConnector.clusterURI is not used. Should we remove it?
fixed, it was oversight.

bq. If two DiskBalancer's are running at the same time, would they somehow balance the same
datanode?

2 balancers will be able to create plans, but any given time we will be able to execute only
one plan for a given datanode. 

bq. Preconditions.checkArgument(x != null);
fixed.

bq. Only the path in JsonNodeConnector.clusterURI is used. Should clusterURI be replaced by
something like clusterFilePath?
fixed 


> DiskBalancer : Add connectors
> -----------------------------
>
>                 Key: HDFS-9449
>                 URL: https://issues.apache.org/jira/browse/HDFS-9449
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-9449-HDFS-1312.001.patch, HDFS-9449-HDFS-1312.002.patch, HDFS-9449-HDFS-1312.003.patch
>
>
> Connectors allow disk balancer data models to connect to an existing cluster - Namenode
or to a json file which describes the cluster. This is used for discovering the physical layout
of the cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message