hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-9441) Do not call construct path string when choosing block placement targets
Date Fri, 20 Nov 2015 01:52:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015016#comment-15015016
] 

Uma Maheswara Rao G edited comment on HDFS-9441 at 11/20/15 1:52 AM:
---------------------------------------------------------------------

Hi [~szetszwo], It make sense to me that we don't use the srcpath in placement policy. If
users really wants to use, they can extract from BlockCollection later I think.

 +1 once removed the unused import in NamenodeFsck class.
 One more point is, need to update javadocs for the API, currently it is saying file path.


was (Author: umamaheswararao):
Hi [~szetszwo], It make sense to me that we don't use the srcpath in placement policy. If
users really wants to use, they can extract from BlockCollection later I think.

 +1 once removed the unused import in NamenodeFsck class.

> Do not call construct path string when choosing block placement targets
> -----------------------------------------------------------------------
>
>                 Key: HDFS-9441
>                 URL: https://issues.apache.org/jira/browse/HDFS-9441
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Minor
>         Attachments: h9441_20151118.patch
>
>
> - INodeFile.getName() is expensive since it involves quite a few string operations. 
The method is called in both ReplicationWork and ErasureCodingWork but the default BlockPlacementPolicy
does not use the returned string.  We should simply pass BlockCollection to reduce unnecessary
computation when using the default BlockPlacementPolicy.
> - Another improvement: the return type of FSNamesystem.getBlockCollection should be changed
to INodeFile since it always returns an INodeFile object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message