hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9438) TestPipelinesFailover assumes Linux ifconfig
Date Wed, 25 Nov 2015 01:05:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025900#comment-15025900

Allen Wittenauer commented on HDFS-9438:

bq. I do see other code also refers to whoami

a) All of the other references: all test code.  Shell.USER_NAME_COMMAND Is never referenced
that I saw.  Removing those should definitely be another JIRA.  However....

b) what value does printing out whoami here actually provide?  whoami is a BSD command that
isn't either installed or in the default path on System V machines.  If it actually provides
some value, we should replace it with the POSIX friendly id.

> TestPipelinesFailover assumes Linux ifconfig
> --------------------------------------------
>                 Key: HDFS-9438
>                 URL: https://issues.apache.org/jira/browse/HDFS-9438
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 2.7.1
>         Environment: Solaris
>            Reporter: Alan Burlison
>            Assignee: John Zhuge
>            Priority: Minor
>         Attachments: HDFS-9438-hdfs-9438.001.patch, HDFS-9438-hdfs-9438.002.patch, HDFS-9438-hdfs-9438.003.patch,
> TestPipelinesFailover.java contains the following:
> {code}
>     scmd = new String[] {"ifconfig"};
>     sce = new ShellCommandExecutor(scmd);
>     sce.execute();
>     System.out.println("'ifconfig' output:\n" + sce.getOutput());
> {code}
> That assumes the Linux ifconfig command. If the flag "-a" is added, the same invocation
should work on both Linux and Solaris - the output is only displayed for debugging purposes
so the fact that the output of ifconfig is different on Linux and Solaris shouldn't matter.

This message was sent by Atlassian JIRA

View raw message