hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9438) TestPipelinesFailover assumes Linux ifconfig
Date Tue, 24 Nov 2015 21:20:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025434#comment-15025434
] 

Yongjun Zhang commented on HDFS-9438:
-------------------------------------

HI [~jzhuge],

Thanks for working on this issue. The patch looks good, one small thing, assumeTrue would
stop the run of this whole test, which means it will fail on windows. I'd suggest that we
make it work this way:

{code}
if (Shell.LINUX || Shell.SOLARIS || Shell.MAC) {
   // Debug code for HDFS-6694
   ......
}
{code}

And we can create a new infra jira to request making ifconfig available in the exe path. If
ifconfig is totally obsoleted, we can replace ifconifg with the new command later.

Thanks.

 

> TestPipelinesFailover assumes Linux ifconfig
> --------------------------------------------
>
>                 Key: HDFS-9438
>                 URL: https://issues.apache.org/jira/browse/HDFS-9438
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 2.7.1
>         Environment: Solaris
>            Reporter: Alan Burlison
>            Assignee: John Zhuge
>            Priority: Minor
>         Attachments: HDFS-9438-hdfs-9438.001.patch, HDFS-9438-hdfs-9438.002.patch, HDFS-9438-hdfs-9438.003.patch
>
>
> TestPipelinesFailover.java contains the following:
> {code}
>     scmd = new String[] {"ifconfig"};
>     sce = new ShellCommandExecutor(scmd);
>     sce.execute();
>     System.out.println("'ifconfig' output:\n" + sce.getOutput());
> {code}
> That assumes the Linux ifconfig command. If the flag "-a" is added, the same invocation
should work on both Linux and Solaris - the output is only displayed for debugging purposes
so the fact that the output of ifconfig is different on Linux and Solaris shouldn't matter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message