hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9410) Fix all HDFS unit tests to correctly reset to sysout and syserr
Date Thu, 12 Nov 2015 20:58:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002916#comment-15002916
] 

Xiao Chen commented on HDFS-9410:
---------------------------------

Hi [~walter.k.su], here comes patch 003 which fixes all similar errors, including the 4 you
mentioned above.
I found this because {{TestDFSAdminWithHA}} failed for me, but your suggestion of fixing them
altogether makes sense. Safer tests are favorable after all. :)
I also updated the title and description of this JIRA.

> Fix all HDFS unit tests to correctly reset to sysout and syserr
> ---------------------------------------------------------------
>
>                 Key: HDFS-9410
>                 URL: https://issues.apache.org/jira/browse/HDFS-9410
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: HDFS
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>            Priority: Minor
>         Attachments: HDFS-9410.001.patch, HDFS-9410.002.patch, HDFS-9410.003.patch
>
>
> Originally found in {{TestDFSAdminWithHA#tearDown}} where System.out.flush() throws an
NPE. 
> The cause is that if for any reason {{setUpHaCluster}} fails before storing {{System.out}}
and {{System.err}} as member variables {{originOut}} and {{originErr}}, then in {{tearDown}}
{{System.out}} and {{System.err}} are set to null. This could cause all following tests to
fail when calling {{flush}}.
> This jira tries to fix all similar occurrences of this issue



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message